louislam / uptime-kuma

A fancy self-hosted monitoring tool
https://uptime.kuma.pet
MIT License
60.16k stars 5.38k forks source link

ghcr.io support #5308

Closed mariomare22 closed 2 weeks ago

mariomare22 commented 2 weeks ago

📑 I have found these related issues/pull requests

Can you please provide also the updated image on ghcr.io?

🏷️ Feature Request Type

Other

🔖 Feature description

at the moment the image is available on docker hub only.

✔️ Solution

please publish it also to github container registry

❓ Alternatives

No response

📝 Additional Context

No response

CommanderStorm commented 2 weeks ago

Why do you want this? 🤔

mariomare22 commented 2 weeks ago

I am running on mikrotik routerOS containers, but it allows using only one registry at time, and most of containers are on github registry but uptime kuma is not :-(

alexislefebvre commented 2 weeks ago

See:

CommanderStorm commented 2 weeks ago

but it allows using only one registry at time

Looking roughly at the docs, it looks like this should be possible.. https://help.mikrotik.com/docs/spaces/ROS/pages/84901929/Container

At least registry-url is a parameter there..

pascaliske commented 2 weeks ago

Why do you want this? 🤔

GHCR has better rate limits and it's also really useful in air-gapped scenarios.

Not to mention how trivial it is to implement this (see those numerous PRs which were opened in the past). 🙂

CommanderStorm commented 2 weeks ago

better rate limits

The rate limits should not matter for pulling images. Do they?

useful in air-gapped scenarios

Could you link specifics? The docker docs don't talk about registry specifc limitations..

Doing effort is fine, but it needs to have a reason.. I currently don't see a benefit to switching registrys or having two registies. Are there other projects that thid this? Could you link to the discussion in their issue tracker?

mariomare22 commented 2 weeks ago

Take lsio, they for istance publish the images to every registry even if they have their own

https://docs.linuxserver.io/images/docker-homeassistant/

mariomare22 commented 2 weeks ago

but it allows using only one registry at time

Looking roughly at the docs, it looks like this should be possible..

https://help.mikrotik.com/docs/spaces/ROS/pages/84901929/Container

At least registry-url is a parameter there..

This parameter is global not as per container

louislam commented 2 weeks ago

I recently improved the build process. #5267

I can give it a try if it is not hard to add the tags.

mariomare22 commented 2 weeks ago

not compared to uptime-kuma but I do this for a fork of caddy I maintain (with dns challenge plugin) to keep the base image up to date. https://github.com/mariomare22/caddy-dns I did not find it hard at all, but I only use latest/main tag

louislam commented 2 weeks ago

Just pushed the nightly images (don't use this on your production), it seems fine.

mariomare22 commented 2 weeks ago

image

<3