louislam / uptime-kuma

A fancy self-hosted monitoring tool
https://uptime.kuma.pet
MIT License
60.16k stars 5.38k forks source link

Create Webhook Option Completly Custom #5332

Closed michel929 closed 1 week ago

michel929 commented 1 week ago

An option that allows you to send two different post requests depending on the status (UP and DOWN)

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules: https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

Description

An option that allows you to send two different post requests depending on the status (UP and DOWN). And that without having to set certain attributes like msg in the body.

Type of change

Please delete any options that are not relevant.

Checklist

louislam commented 1 week ago

Too hacky. It is not a valid content-type at all.

I think you should handle Uptime Kuma's Webhook format in your application, rather than modify Uptime Kuma in my opinion.

Recommended Pull Request Guideline

Before diving deep into coding, having a discussion first by creating an empty pull request for discussion is preferred.

michel929 commented 1 week ago

Hm, ok, I understand, but there would be a lot of good opportunities to inform customers automatically in your own customer system. Or you could also communicate directly with the Uptime Kuma WebAPI, which creates an automatic incident, for example.