louislam / uptime-kuma

A fancy self-hosted monitoring tool
https://uptime.kuma.pet
MIT License
60.3k stars 5.39k forks source link

fix(status page): Make sure the group deletion is correctly handled when `groupIDList` is empty #5340

Closed Ionys320 closed 1 week ago

Ionys320 commented 1 week ago

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules: https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

Description

Fixes #5336

Type of change

Please delete any options that are not relevant.

Checklist

Note: If I run ESLint, I get 41897 problems (41897 errors, 0 warnings) by using lint:js, because error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style.

Ionys320 commented 1 week ago

(Sorry for closing the PR, I tried to remove the fix(tags) commit, but it's I didn't manage to).

CommanderStorm commented 1 week ago

tried to remove the fix(tags) commit

No need to. We squash commits (unless something else makes sense) anyway ^^

Ionys320 commented 1 week ago

Okay, good to know then!