feat(monitor condition): Remove the empty default condition creation

[Ionys320]

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules: https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

• [x] I have read and understand the pull request rules.

Description

The first PR related to monitors conditions were adding an empty condition. This has been removed since an empty condition disallow monitor saving. Please note this merge may be unwanted the default condition were a feature (but maybe unwished after all?).

E2E has been updated to avoid considering we have a default condition (all conditions count has been reduced by 1, etc).

Fixes #5303

Type of change

Please delete any options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• User interface (UI)

Checklist

• [x] My code follows the style guidelines of this project
• [x] I ran ESLint and other linters for modified files
• [x] I have performed a self-review of my own code and tested it
• [ ] I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
• [x] My changes generates no new warnings
• [x] My code needed automated testing. I have added them (this is optional task)

[CommanderStorm]

My concearn in https://github.com/louislam/uptime-kuma/pull/5048#discussion_r1730428445 was that

Currently, I think a good percentage of people would not find this functionality and would be then somewhat confused..

=> we need to find a better way to add this only for new monitors. Sadly, I have not had the time to debug how to differentiated the 1.0 and 2.0 DNS monitors and if they are different.

[CommanderStorm]

Likely extending the dns monitor instead to include an "Record Exists" functionality or setting a wildcard as the default would be better.

[Ionys320]

Regarding DNS, adding a default condition may be done during the migration from v1 to v2, no?

[CommanderStorm]

Yes, that is a possibility

[Ionys320]

Likely extending the dns monitor instead to include an "Record Exists" functionality or setting a wildcard as the default would be better.

I prefer the default wildcard. Using defaut values allows us to keep the conditions system for future monitors without needing too much work.