louislam / uptime-kuma

A fancy self-hosted monitoring tool
https://uptime.kuma.pet
MIT License
60.3k stars 5.39k forks source link

feat(tests): Add more Unit tests #5364

Open Zaid-maker opened 5 days ago

Zaid-maker commented 5 days ago

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules: https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

Description

Add more Tests tests might get failed

Type of change

Please delete any options that are not relevant.

Checklist

Screenshots (if any)

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

Zaid-maker commented 4 days ago

I don't know why the backend-test failing I found no error in it still fails. Needs to look into it.

louislam commented 3 days ago

I don't know why the backend-test failing I found no error in it still fails. Needs to look into it.

When checking the url, I think you should parse into a URL by using new URL(...) for security.

Zaid-maker commented 2 days ago

When checking the url, I think you should parse into a URL by using new URL(...) for security.

Ohh that could work i will look into into it!