louislam / uptime-kuma

A fancy self-hosted monitoring tool
https://uptime.kuma.pet
MIT License
57.63k stars 5.21k forks source link

Add login button on status page #544

Open Giraffaman opened 3 years ago

Giraffaman commented 3 years ago

Is your feature request related to a problem? Please describe. While trying out the new status page, I found there does not seem to be any way to log back into the dashboard when you access the page while not logged in. As far as I can tell, the only way to get to the login screen is by changing the URL to ".../dashboard".

Describe the solution you'd like When accessing the status page while logged in, there's a button which leads back to the dashboard. It would be cool if a similar button would be displayed for unauthenticated users so they can use that to log into the dashboard.

I realize this is not super critical and I'm super glad a nice customizable public status page now exists in the first place, but I just thought I'd leave this here in case someone has the time and skill to add this little enhancement. Thank you and keep up the great work!

mariushosting commented 3 years ago

I disagree the status page must not lead to any login page

Giraffaman commented 3 years ago

I disagree the status page must not lead to any login page

Just to be clear: I don't mean that users should have to login before accessing the status page. What I mean is that there should be a login-button on the status page so that unauthenticated users can use that button to login to the dashboard to e.g. create an incident message.

So to show what I mean: Authenticated users can go to the status page from the dashboard: 20211004175800_flameshot

Authenticated users already have a button on the status page to go back to the dashboard: 20211004175903_flameshot

However, non-authenticated users should also get a button to get to the dashboard (via the login page of course): 20211004180128_flameshot This would be especially useful if Uptime Kuma's entry page is set to be the status page.

mariushosting commented 3 years ago

I absolutely disagree. The status page must not lead to any login/button page. This is a Status Page and must be left as is. If you want to login just go to /dashboard.

Giraffaman commented 3 years ago

I absolutely disagree. The status page must not lead to any login/button page. This is a Status Page and must be left as is. If you want to login just go to /dashboard.

I get that it's not a huge inconvenience to simply navigate to /dashboard to log in, but might I ask about the reason for your strong disagreement? Do you think it would pose a security risk, or is it simply because you want to keep the status page as clean as possible? While I don't know how complex it would be to implement that, I could see adding an option like "show login button on status page=true|false".

deefdragon commented 3 years ago

I agree with having a login button, but also requiring it to have a setting. I want the ability to log in on mobile, and the default page is the status page. Its a minor, but persistent pain to have to re-navigate to the dashboard page every time I want to log in on mobile.

chakflying commented 3 years ago

Thinking about this, I guess we could have a default setting where it checks if the user has previously logged in before on this browser, i.e. check the local storage for existing keys/settings. This would be non-intrusive for visitors but convenient for admins.

marcusquinn commented 2 years ago

Thinking about this, I guess we could have a default setting where it checks if the user has previously logged in before on this browser, i.e. check the local storage for existing keys/settings. This would be non-intrusive for visitors but convenient for admins.

This is the answer, yes please.

marcusquinn commented 2 years ago

/admin would make more sense for the URL being guessable too please. Took me ages to find this information with a non-conventional URL.

EsEnZeT commented 2 years ago

@louislam this is very inconvenient when status page is default one and user is not logged in. You need to remember url and type by hand then.

Computroniks commented 2 years ago

Thinking about this, I guess we could have a default setting where it checks if the user has previously logged in before on this browser, i.e. check the local storage for existing keys/settings. This would be non-intrusive for visitors but convenient for admins.

I think for this @chakflying idea would be the best. Personally, I don't want to advertise to end users where my login page is and I think that it would disrupt the smooth design of the page. By checking if the user has previously been logged in we would avoid this.

/admin would make more sense for the URL being guessable too please. Took me ages to find this information with a non-conventional URL.

Whilst it does make more sense to have something like /admin, I don't think that there is much we can do about this now. If we change it then we would just end up with even more confusion. A better solution would be to make it more prominent in the documentation that for admin jobs the user should go to /dashboard

deefdragon commented 2 years ago

Note that the site is always advertising that it is uptime Kuma, and that won't change. Thus making it really easy to figure out what the admin page is. While security through obscurity can be OK as an extra minor layer, it's not worth bikeshedding for more than a comment or two, and ease of admin use likely takes priority anyway.

Computroniks commented 2 years ago

Note that the site is always advertising that it is uptime Kuma, and that won't change. Thus making it really easy to figure out what the admin page is. While security through obscurity can be OK as an extra minor layer, it's not worth bikeshedding for more than a comment or two, and ease of admin use likely takes priority anyway.

I know. If someone wanted to try hard enough then they could look it up and go to the login page. My point is more for the average slightly inquisitive user who normally couldn't be bothered to look it up being given a more direct way. Personally, my bigger issue would be breaking up the feel of the status page which is why I like @chakflying idea.

Ran-Xing commented 1 year ago

@Computroniks +1, very good

Ran-Xing commented 1 year ago

I can't find the login entry many times, only to this issues you look for, maybe I should add a bookmark

regchanuk commented 1 year ago

The work around is sticking link on the Footer of the page to get around this Not conventional though but works not sure if people look below this

service provided by me

Service pages https://uptime.domain.com/dashboard

added code for the url <a href="https://uptime.your domain.com">Service page</a> shorted URL to this and works <a href="/dashboard">Service page</a> looks like Service page