search

louislam / uptime-kuma

A fancy self-hosted monitoring tool
https://uptime.kuma.pet
MIT License
56.59k stars 5.08k forks source link

[Bug]: incorrect PingChart display during Daylight Saving Time transition #843

Open luckyluc74 opened 2 years ago

luckyluc74 commented 2 years ago

👟 Reproduction steps

Just let uptime-kuma run from summertime to wintertime ( FYI my time zone is Central European Time (CET) )

👍 Expected behavior

correct display of responsetime metrics

👎 Actual Behavior

responsetime metrics are overlapping

🐻 Uptime-Kuma version

1.10.0

💻 Operating System

Ubuntu 20.04.3 LTS (GNU/Linux 5.4.143-1-pve x86_64)

🌐 Browser

Waterfox Classic

🐋 Docker

20.10.10

🏷️ Docker Image Tag

louislam/uptime-kuma latest 00738a940895

🟩 NodeJS Version

No response

📝 Relevant log output

No response

⚠️ Please verify that this bug has NOT been raised before.

🛡️ Security Policy

luckyluc74 commented 2 years ago

2021-10-31 08_12_27-Uptime Kuma - Waterfox Classic 2021-10-31 08_11_57-Uptime Kuma - Waterfox Classic

Sometimes a picture is worth more than 1000 words :)

louislam commented 2 years ago

~Duplicate of https://github.com/louislam/uptime-kuma/issues/285~

chakflying commented 2 years ago

Thanks for an actual repo of the issue! Now I know why it happens.

Unfortunately it may not be an easy fix, as I found out day.js doesn't seem to handle daylight saving transitions correctly. I guess I can switch to another date handling library just for the chart.

luckyluc74 commented 2 years ago

You are welcome. It only occurs during daylight savings transitions, so that means only twice a years. Personally I can live with this bug, but just to make aware that this bug occurs. I can image that development effort can be better spend on more critical issues :)