louismullie / stanford-core-nlp

Ruby bindings to the Stanford Core NLP tools (English, French, German).
Other
432 stars 70 forks source link

JRuby support #10

Closed colinsurprenant closed 11 years ago

colinsurprenant commented 11 years ago

here's a first shot at supporting JRuby, issue #8.

the goal was avoid breaking the api - all tests are passing in both MRI and JRuby. I was able to extract the specific bits in both mri_binding.rb and jruby_binding.rb and keep the common code in stanford-core-nlp.rb.

the only thing I modified was to set the default jar_path to deps/ instead of bin/

louismullie commented 11 years ago

Thanks a lot!