search

louismullie / stanford-core-nlp

Ruby bindings to the Stanford Core NLP tools (English, French, German).
Other
432 stars 70 forks source link

Add gemspec requirements attribute #45

Closed guilhermesimoes closed 1 year ago

guilhermesimoes commented 7 years ago

This information will appear on the gem's page on rubygems.org. http://guides.rubygems.org/specification-reference/#requirements

arbox commented 7 years ago

@guilhermesimoes that's very useful, thank you! But I think, we should elaborate this message a bit. I'll prepare the end version of the README with the installation section, so we could link to it from the post install message.

guilhermesimoes commented 7 years ago

Just want to clarify that post_install_message is one thing, requirements is another. requirements are only visible on rubygems.org. And long requirements messages usually don't look so good. Here are some examples:

arbox commented 7 years ago

@guilhermesimoes sorry, I expressed my thoughts misleading. Since requirements is a free text field we could elaborate the message, and then link to is as well from the post_install_message. We need a string variable for that. The text should contain the minimum version, 3.5.0 is a good default. Thank you for your help and ideas!

guilhermesimoes commented 7 years ago

Aah, that makes sense. Please feel free to edit this PR or close it and create a totally new commit :smile: