search

louismullie / stanford-core-nlp

Ruby bindings to the Stanford Core NLP tools (English, French, German).
Other
433 stars 70 forks source link

*tiny* regex fix #6

Closed wsh closed 12 years ago

wsh commented 12 years ago

Dear Louis,

Thank you so much for your invaluable library: I've been using it on Windows (not my choice) and in so doing noticed this little problem. Windows's default Ruby install path includes 'C:\Ruby193\lib' in the path for gems: your gsub killed that and caused mysterious errors. The changed regex ensures that lib is only removed at the end of the path.

Hope all's well, and thank you again for this (and for treat!), Will

louismullie commented 12 years ago

Ah-ah! Thanks a bunch, I appreciate since I don't have a Windows box to test on. So with this fix it does work on Windows? If you can have a quick look at this other Windows issue and confirm whether it is fixed, I'll be forever grateful :) https://github.com/louismullie/stanford-core-nlp/issues/3

wsh commented 12 years ago

Indeed it does: I haven't encountered anything like the other issue, and the gem is up and running now. Thanks again for a fantastic library!

louismullie commented 12 years ago

Ok, cheers!