search

louismullie / stanford-core-nlp

Ruby bindings to the Stanford Core NLP tools (English, French, German).
Other
432 stars 70 forks source link

Support JRuby as well as RJB. #8

Closed headius closed 11 years ago

headius commented 11 years ago

JRuby provides everything RJB does and more. It shouldn't be hard to support it.

louismullie commented 11 years ago

Yes, I've been thinking about this for a long time. This gem was originally designed for Treat, which uses so many C extensions that I never would've hoped to make it JRuby-compatible. But I understand that a lot of people are looking to use this as a standalone gem, and JRuby support should be added. That said, time hasn't been abundant lately, so I can't say this is high on my priority list...

louismullie commented 11 years ago

Alright, I'm going to do a little bit more testing before pushing, but this seems ready to go.

headius commented 11 years ago

Excellent! Let us know if you need any assistance! You may need to release a separate gem that has "java" platform to avoid the rjb dependency on JRuby.

louismullie commented 11 years ago

Alright, I've abstracted out all of the JRuby vs. Rjb nuts and bolts from @colinsurprenant into bind-it. I also took the opportunity to make some nicer specs for English, French and German, which revealed a few bugs that were fixed. All the specs for the three languages are now working on MRI 1.9.2, 1.9.3 and JRuby 1.6.4 and 1.7.1.

I also decided to scrap the Arabic and Chinese support, after further communication with the Stanford NLP group which determined that these are not well supported enough through Stanford Core NLP to be easily usable.

I pushed the new version as 0.4.0, and welcome your help in making sure it works across a variety of platforms :)

Louis

headius commented 11 years ago

Thanks for the patches, @colinsurprenant, and thanks for the release, @louismullie!

colinsurprenant commented 11 years ago

Good stuff @louismullie Thanks!