louismullie / treat

Natural language processing framework for Ruby.
Other
1.36k stars 128 forks source link

Allow Treat::Core::Installer.install to accept schiphol download options, eg. suppress progress bar for some terminals #60

Closed jerrydboonstra closed 7 years ago

jerrydboonstra commented 11 years ago

I was not able to run the installer on my Chef-based AWS Opsworks -based Rails application deploy, it would fail with tput: unknown terminal "unknown"

Suppressing the progress bar fixed this, so I changed the install method signature to allow passing in options to the downloader.

Sorry this is my first pull request: not sure how to exclude my README.md file changes without rebranching or something.

agarie commented 10 years ago

You can remove the changes in the files and commit these to your fork. Probably just removing the "Fork changes" is enough. :+1: