search

louisremi / jquery.transition.js

Upgrade jQuery's .animate() method to use CSS3 Transitions in modern browsers.
436 stars 81 forks source link

animating 2 properties sets the last property in transition twice #13

Closed fresh-bagel closed 12 years ago

fresh-bagel commented 12 years ago

when running an animation command with 2 properties the generated css on the element is wrong. to reproduce run this command: $element.animate({left: '0px',opacity: 1},10000,'linear') the css that is generated is: -webkit-transition: opacity 10000ms linear, opacity 10000ms linear instead of: -webkit-transition:left 10000ms linear, opacity 10000ms linear

it seems that the last property is being inserted to the css instead of the first property.

louisremi commented 12 years ago

Wow, this seems to be a serious regression, how come I didn't spot it?? I'll investigate asap, thanks

fresh-bagel commented 12 years ago

great! thanks a lot!!

louisremi commented 12 years ago

Alright, I think I found the problem, fortunately it did not break the animations (or did it). But that was a serious problem indeed, thanks for spotting it. Patch is on the way

louisremi commented 12 years ago

Can you confirm that the last commit fixed the problem?

fresh-bagel commented 12 years ago

works great now. once again - thanks a lot!

please notice that when I download the zip I don't get the latest revision with the fix - I had to take the file from the files list in order to test the fix (I don't have much experience with the git system so I don't know if this is the way it should be or not)

louisremi commented 12 years ago

Maybe you re-downloaded the zip before I uploaded the new one. The scripts in the current zip include the fix.