search

louisremi / jquery.transition.js

Upgrade jQuery's .animate() method to use CSS3 Transitions in modern browsers.
436 stars 81 forks source link

Have a look and tell me what you think ;) #2

Closed brokenseal closed 13 years ago

brokenseal commented 13 years ago

Properties are now listed as single properties rather then one single statement. Jslinted.

louisremi commented 13 years ago

Hi, thank you for taking the time to issue a pull request.

I'm afraid I will have to refuse it in its current form: you should create branches to fix a bug, and you should create different branches to create different bugs. The jQuery documentation has a good explanation about pull request, I suggest you have a look at it: http://docs.jquery.com/Getting_Involved#Committing_and_Pull_Requests Having the jsLint fix and your other fix in the same branch makes it really hard to review the pull request.

I should also point out to the jQuery Core Style Guidelines, used in this plugin: http://docs.jquery.com/JQuery_Core_Style_Guidelines You will find the jsLint rules ignored in the jQuery source.

Thank you again,

Louis-Rémi

brokenseal commented 13 years ago

Hi, thank you for the documentation you've linked in your message, I'll have a look at it and make a better pull request :)

David.