search

louketo / louketo-proxy

A OpenID / Proxy service
Apache License 2.0
950 stars 345 forks source link

Replace satori/go.uuid by gofrs/uuid (#611) #612

Closed abstractj closed 4 years ago

abstractj commented 4 years ago

Fixes #611

abstractj commented 4 years ago

This makes sense. Must seems a bit weird, are there any ways we could get around this? Should we follow up on that at some point? Could create an issue for now, it's not blocking

@JoelSpeed the other alternative is to do the traditional error handling. Something like:

uuid, err := uuid.NewV4()
if err !=nil {
//handle the error here
}
//do something with uuid.String()

A bit more verbose, but if you have a strong feeling about using Must, I can do the refactor. Wdyt?

JoelSpeed commented 4 years ago

It would be more correct to take the error and return a 500 I would say

abstractj commented 4 years ago

@JoelSpeed ready for another round.