Open xeor opened 4 years ago
@xeor it seems to me like a duplicate of https://github.com/louketo/louketo-proxy/issues/524. Could you please confirm and close?
@abstractj this is not a duplicate.. This is about adding domains as a valid resource-url. #524 is about adding different endpoints per resource.
A single upstream can handle multiple hosts now as well by using --preserve-host=true
, but you can't use it for anything useful, since you are can't specify which roles should be valid per host (since you can only specify resources based on url-paths).
vhost in resources[].uri
Summary
It would be useful to be able to specify a hostname in the resource-uri field so you could point multiple domains at louketo-proxy.
Why?
It would make configuration like this simpler.
Instead, we could do:
or specify the whole domain.
It's much easier to setup services as separate sub-domains than on dedicated sub-paths. Often, sub-paths need app-configuration and the app needs to support it. Let's encrypt also have support for wildcard domains now, which is going to make this a very attractive setup.
How
It looks like
uri
are already prefixed with a/
, so it doesnt seam to be a feature that needs an api-change.uri
can also bedomain
, so you will get--resources=domain=jira.*
Acceptance criteria
Support for using domains/sub-domains as resources