search

louketo / louketo-proxy

A OpenID / Proxy service
Apache License 2.0
950 stars 343 forks source link

Adding ARM architecture #681

Open Beanow opened 4 years ago

Beanow commented 4 years ago

Summary

Adding ARM v6 / v7 (32bit) and ARM v8 (64bit) to the build architectures.

Why?

ARM CPUs are typical for Raspberry Pi-like or consumer NAS servers. Adding an ARM build here would allow more flexible protection of resources on low-power / SoC devices like these.

How

Including the additional architectures in the CI and deploy pipeline.

Acceptance criteria

Running the quay.io/louketo/louketo-proxy image on a linux/arm/v7 or linux/arm64 Docker host finds and runs a build suitable for the architecture.

(Personally I don't need v6 support or non-linux OS)

Additional Information

Other ARM versions exist, though I'm basing this on official Docker support ranges. https://github.com/docker-library/official-images#architectures-other-than-amd64

Targeting one of v6 / v7 for 32bits and v8 for 64bits seems to be the most common.

lyndon160 commented 4 years ago

The images and its dependencies appear to be compatible with Arm64v8 already.

It can be built using: docker buildx build --platform linux/amd64,linux/arm64 --push -t louketo/louketo-proxy . This generates both images, and creates a manifest file for them.

To do this locally, use --load instead of push.