Goverment refactor 2

[LT-Rascek]

Rewriting PR #72 on top of Patch 1.5

Commit is based on top of PR #74 and PR #76.

Governments

• [ ] Finish and have High Tribal Government Approved
  • Overhaul Realm Laws
  • Review Vassal Contracts
  • Review available succession laws
  • Review Government Character Modifiers
  • Implement Localization, including non-functional flag for character modifiers
  • Implement Game Concepts
• [ ] Finish and have Pre-Feudal Government Approved
  • Overhaul Realm Laws
  • Review Vassal Contracts
  • Review available succession laws
  • Review Government Character Modifiers
  • Implement Localization, including non-functional flag for character modifiers
  • Implement Game Concepts
• [ ] Finish and have Nomad Government Approved
  • Overhaul Realm Laws
  • Review Vassal Contracts
  • Review available succession laws
  • Review Government Character Modifiers
  • Implement Localization, including non-functional flag for character modifiers
  • Implement Game Concepts
• [ ] Finish and have Sub-Roman Government Approved
  • Overhaul Realm Laws
  • Review Vassal Contracts
  • Review available succession laws
  • Review Government Character Modifiers
  • Implement Localization, including non-functional flag for character modifiers
  • Implement Game Concepts
• [ ] Finish and have Eranshar Government Approved
  • Overhaul Realm Laws
  • Review Vassal Contracts
  • Review available succession laws
  • Review Government Character Modifiers
  • Implement Localization, including non-functional flag for character modifiers
  • Implement Game Concepts
• [ ] Finish and have Gupta Government Approved
  • Overhaul Realm Laws
  • Review Vassal Contracts
  • Review available succession laws
  • Review Government Character Modifiers
  • Implement Localization, including non-functional flag for character modifiers
  • Implement Game Concepts
• [ ] Finish and have Bureaucratic Government Approved
  • Overhaul Realm Laws
  • Review Vassal Contracts
  • Review available succession laws
  • Review Government Character Modifiers
  • Implement Localization, including non-functional flag for character modifiers
  • Implement Game Concepts

Factions

• [x] Implement Tax Revolt Faction for Bureaucrats
• [ ] Overhaul casus belli & factions in light of having more than just crown_authority available

On Actions

• [ ] Implement a game_start on_action effect to properly set realm laws in a (mostly) automated way.
  • Better than doing it in history because it prevent the risk of overwriting during automatic assignment of realm laws
• [ ] Rework succession laws to use game triggers instead of in history
  • More readily throws errors to error.log
  • Puts succession information in a central location instead of spread across hundreds of files

Succession Laws

• NB: This should only be done after the government designs are settled
• [ ] Overhaul Imperial Elective Succession Law (for Bureaucratic)
• [ ] Overhaul Mahestan Succession Law (for Eranshar)
• [ ] Implement Gubernatorial Succession Law (for Gubernatorials)
• [ ] Implement something like "elective gavelkind" for tribals
• [ ] Implement Turkish Succession for Turks

Other

• [x] Add new government opinion modifiers (if possible)
  • e.g., subroman_government_vassal_opinion = -10
  • Not possible it turns out

Decision

• [ ] Review Tribal to High Tribal decision
• [ ] Impelement nomad settlement decision
• [ ] Review adopt subroman decision
• [ ] Review adopt bureaucratic decision
• [ ] Review adopt feudalism decision

Tributaries and Foederati

• [ ] Fixup Foederatus contract
• [ ] Nix other vassal contracts for tributaries (so that only the Tributary contract applies); otherwise, we get very weird (low) values for levies/taxes.
  • Not possible; will need to think of better way around
• [x] Reimplement Tributary States
• [ ] Fix Tributaries, Foederati, Tributary States not being releasable by modify feudal contract window
• [ ] Review Tributaries, Foederati vis-a-vis councils
• [ ] Implement Tributary Wars
• [ ] Implement "Demand Tributary" Interaction

Localization

• [ ] Import Eranshar localizations from WtWSMS

Bugfixes

• [ ] Zeno not inheriting realm taxation laws correctly and becoming subroman
• [ ] Fix independence on modifying High Tribal contracts
• [ ] Fix High Tribals not able to change succession laws
• [ ] Fix "Change succession Law" Button not allowing non-clan/feudals to change succession law (error lists crown authority)
• [ ] Fix Title on action not properly reverting eranshar government on succession
• [ ] Fix interaction_modify_vassal_window.gui yield false "becomes independent" signals in foederatus negotiations

Notes:

• Title revocation revokes the whole duchy/kingdom in CK3, so no free title revocation given for gubernatorial vassals at this time.