Compatibility with vanilla 3.0

[loup99]

Issue to track progress on compatibility with patch 3.0.x.

[IhateTrains]

Problem: outremer culture hasn't been added to cultures folder.

[IhateTrains]

Common folder:

• [x] Problem: bosnian and carantanian cultures haven't been added to the cultures folder.

• [x] Problem: is_inaccessible_or_incapable_trigger has two (duplicate) definitions.

• [x] Problem: religion_openly_hellenic_or_reformed_trigger scripted trigger doesn't seem to exist.

• [x] Problem: religion_feature_hellenic seems to be missing.

• [ ] Duplicate dynasty IDs: 1059971, 105946, 1100015, 1100014, 1100012, 1100011, 1100010, 1100009, 1100008, 1100007, 1100006, 1100005, 1100003, 1061019

[loup99]

Problem: bosnian and carantanian cultures haven't been added to the cultures folder.

Those we already have, that will be replace.

[IhateTrains]

We could use the new vanilla codenames for better future compatibility.

[IhateTrains]

I will put all the problems in one checklist comment from now on.

[loup99]

It closed automatically, I don't know why. It is better if you add new posts though because it notifies us.

[IhateTrains]

OK, I can add them in both places to see both the notifications and the summary. EDIT: It closed the issue because you added "fixes" before the reference.

[loup99]

EDIT: It closed the issue because you added "fixes" before the reference.

How do you disable this?

[IhateTrains]

I don't know if you can, but you can try in the repo settings.

[IhateTrains]

religion_feature_hellenic seems to be missing.

[IhateTrains]

Decisions folder:

• [x] There are references to vanilla arabic culture group in conversion_decisions.txt
• [x] Duplicate (LI + vanilla) convert_to_spouse_religion Merging them may be difficult because the code and conditions differ a lot.

[IhateTrains]

^ common folder: Duplicate dynasty IDs: 1059971, 105946, 1100015, 1100014, 1100012, 1100011, 1100010, 1100009, 1100008, 1100007, 1100006, 1100005, 1100003, 1061019

[IhateTrains]

^ decision folder: duplicate (LI + vanilla) convert_to_spouse_religion Merging them may be difficult because the code and conditions differ a lot.

[IhateTrains]

Validator output on interface:

At \interface\portrait_properties\00_portrait_properties.txt [31\13] (Line 5943, column 2): The required "factor" entry was not found.

At \interface\portrait_properties\00_portrait_properties.txt [31\12] (Line 5934, column 2): The required "factor" entry was not found.

At \interface\portrait_properties\00_portrait_properties.txt [31\11] (Line 5925, column 2): The required "factor" entry was not found.

At \interface\portrait_properties\00_portrait_properties.txt [31\10] (Line 5916, column 2): The required "factor" entry was not found.

At \interface\portrait_properties\00_portrait_properties.txt [31\5] (Line 5866, column 2): The required "factor" entry was not found.

At \interface\portrait_properties\00_portrait_properties.txt [31\4] (Line 5861, column 2): The required "factor" entry was not found.

At \interface\portrait_properties\00_portrait_properties.txt [31\3] (Line 5856, column 2): The required "factor" entry was not found.

At \interface\portrait_properties\00_portrait_properties.txt [31\2] (Line 5851, column 2): The required "factor" entry was not found.

At \interface\portrait_properties\00_portrait_properties.txt [5\11\modifier\OR\graphical_culture] (Line 3112, column 5): "serb_southslavicgfx" is not a valid GraphicalCultureType or MaybeEventTargetChar.

At \interface\portrait_properties\00_portrait_properties.txt [5\11\modifier\graphical_culture] (Line 3104, column 4): "croat_southslavicgfx" is not a valid GraphicalCultureType or MaybeEventTargetChar.

At \interface\portrait_properties\00_portrait_properties.txt [5\8\modifier\OR\graphical_culture] (Line 2906, column 5): "serb_southslavicgfx" is not a valid GraphicalCultureType or MaybeEventTargetChar.

At \interface\portrait_properties\00_portrait_properties.txt [5\8\modifier\graphical_culture] (Line 2898, column 4): "croat_southslavicgfx" is not a valid GraphicalCultureType or MaybeEventTargetChar.

At \interface\portrait_properties\00_portrait_properties.txt [5\8\modifier\OR\graphical_culture] (Line 2873, column 5): "serb_southslavicgfx" is not a valid GraphicalCultureType or MaybeEventTargetChar.

At \interface\portrait_properties\00_portrait_properties.txt [5\8\modifier\graphical_culture] (Line 2865, column 4): "croat_southslavicgfx" is not a valid GraphicalCultureType or MaybeEventTargetChar.

At \interface\portrait_properties\00_portrait_properties.txt [5\5\modifier\OR\graphical_culture] (Line 2679, column 5): "serb_southslavicgfx" is not a valid GraphicalCultureType or MaybeEventTargetChar.

At \interface\portrait_properties\00_portrait_properties.txt [5\5\modifier\graphical_culture] (Line 2671, column 4): "croat_southslavicgfx" is not a valid GraphicalCultureType or MaybeEventTargetChar.

At \interface\portrait_properties\00_portrait_properties.txt [1\11\modifier\OR\graphical_culture] (Line 1125, column 5): "serb_southslavicgfx" is not a valid GraphicalCultureType or MaybeEventTargetChar.

At \interface\portrait_properties\00_portrait_properties.txt [1\11\modifier\graphical_culture] (Line 1114, column 4): "croat_southslavicgfx" is not a valid GraphicalCultureType or MaybeEventTargetChar.

At \interface\portrait_properties\00_portrait_properties.txt [1\10\modifier\OR\graphical_culture] (Line 1067, column 5): "serb_southslavicgfx" is not a valid GraphicalCultureType or MaybeEventTargetChar.

At \interface\portrait_properties\00_portrait_properties.txt [1\10\modifier\graphical_culture] (Line 1056, column 4): "croat_southslavicgfx" is not a valid GraphicalCultureType or MaybeEventTargetChar.

At \interface\portrait_properties\00_portrait_properties.txt [1\6\modifier\higher_real_tier_than] (Line 879, column 4): "unlanded" is not a valid Tier or MaybeEventTargetCharTitle.

At \interface\portrait_properties\00_portrait_properties.txt [1\5\modifier\OR\graphical_culture] (Line 862, column 5): "serb_southslavicgfx" is not a valid GraphicalCultureType or MaybeEventTargetChar.

At \interface\portrait_properties\00_portrait_properties.txt [1\5\modifier\graphical_culture] (Line 851, column 4): "croat_southslavicgfx" is not a valid GraphicalCultureType or MaybeEventTargetChar.

At \interface\portrait_properties\00_portrait_properties.txt [1\4\modifier\OR\graphical_culture] (Line 802, column 5): "serb_southslavicgfx" is not a valid GraphicalCultureType or MaybeEventTargetChar.

At \interface\portrait_properties\00_portrait_properties.txt [1\4\modifier\graphical_culture] (Line 791, column 4): "croat_southslavicgfx" is not a valid GraphicalCultureType or MaybeEventTargetChar.

At \interface\portrait_properties\00_portrait_properties.txt [1\2\modifier\OR\graphical_culture] (Line 718, column 5): "serb_southslavicgfx" is not a valid GraphicalCultureType or MaybeEventTargetChar.

At \interface\portrait_properties\00_portrait_properties.txt [1\2\modifier\graphical_culture] (Line 707, column 4): "croat_southslavicgfx" is not a valid GraphicalCultureType or MaybeEventTargetChar.

At \interface\portrait_properties\00_portrait_properties.txt [0\18\modifier\NOT\has_landed_title] (Line 480, column 12): "k_hellenic_pagan" is not a valid AnyTitle, MaybeEventTargetTitle, or No.

At \interface\portrait_properties\00_portrait_properties.txt [0\9\modifier\OR\has_landed_title] (Line 263, column 5): "k_hellenic_pagan" is not a valid AnyTitle, MaybeEventTargetTitle, or No.

[loup99]

Validator output on interface:

At \interface\portrait_properties\00_portrait_properties.txt [31\13] (Line 5943, column 2): The required "factor" entry was not found.

At \interface\portrait_properties\00_portrait_properties.txt [31\12] (Line 5934, column 2): The required "factor" entry was not found.

At \interface\portrait_properties\00_portrait_properties.txt [31\11] (Line 5925, column 2): The required "factor" entry was not found.

At \interface\portrait_properties\00_portrait_properties.txt [31\10] (Line 5916, column 2): The required "factor" entry was not found.

At \interface\portrait_properties\00_portrait_properties.txt [31\5] (Line 5866, column 2): The required "factor" entry was not found.

At \interface\portrait_properties\00_portrait_properties.txt [31\4] (Line 5861, column 2): The required "factor" entry was not found.

At \interface\portrait_properties\00_portrait_properties.txt [31\3] (Line 5856, column 2): The required "factor" entry was not found.

At \interface\portrait_properties\00_portrait_properties.txt [31\2] (Line 5851, column 2): The required "factor" entry was not found.

At \interface\portrait_properties\00_portrait_properties.txt [5\11\modifier\OR\graphical_culture] (Line 3112, column 5): "serb_southslavicgfx" is not a valid GraphicalCultureType or MaybeEventTargetChar.

At \interface\portrait_properties\00_portrait_properties.txt [5\11\modifier\graphical_culture] (Line 3104, column 4): "croat_southslavicgfx" is not a valid GraphicalCultureType or MaybeEventTargetChar.

At \interface\portrait_properties\00_portrait_properties.txt [5\8\modifier\OR\graphical_culture] (Line 2906, column 5): "serb_southslavicgfx" is not a valid GraphicalCultureType or MaybeEventTargetChar.

At \interface\portrait_properties\00_portrait_properties.txt [5\8\modifier\graphical_culture] (Line 2898, column 4): "croat_southslavicgfx" is not a valid GraphicalCultureType or MaybeEventTargetChar.

At \interface\portrait_properties\00_portrait_properties.txt [5\8\modifier\OR\graphical_culture] (Line 2873, column 5): "serb_southslavicgfx" is not a valid GraphicalCultureType or MaybeEventTargetChar.

At \interface\portrait_properties\00_portrait_properties.txt [5\8\modifier\graphical_culture] (Line 2865, column 4): "croat_southslavicgfx" is not a valid GraphicalCultureType or MaybeEventTargetChar.

At \interface\portrait_properties\00_portrait_properties.txt [5\5\modifier\OR\graphical_culture] (Line 2679, column 5): "serb_southslavicgfx" is not a valid GraphicalCultureType or MaybeEventTargetChar.

At \interface\portrait_properties\00_portrait_properties.txt [5\5\modifier\graphical_culture] (Line 2671, column 4): "croat_southslavicgfx" is not a valid GraphicalCultureType or MaybeEventTargetChar.

At \interface\portrait_properties\00_portrait_properties.txt [1\11\modifier\OR\graphical_culture] (Line 1125, column 5): "serb_southslavicgfx" is not a valid GraphicalCultureType or MaybeEventTargetChar.

At \interface\portrait_properties\00_portrait_properties.txt [1\11\modifier\graphical_culture] (Line 1114, column 4): "croat_southslavicgfx" is not a valid GraphicalCultureType or MaybeEventTargetChar.

At \interface\portrait_properties\00_portrait_properties.txt [1\10\modifier\OR\graphical_culture] (Line 1067, column 5): "serb_southslavicgfx" is not a valid GraphicalCultureType or MaybeEventTargetChar.

At \interface\portrait_properties\00_portrait_properties.txt [1\10\modifier\graphical_culture] (Line 1056, column 4): "croat_southslavicgfx" is not a valid GraphicalCultureType or MaybeEventTargetChar.

At \interface\portrait_properties\00_portrait_properties.txt [1\6\modifier\higher_real_tier_than] (Line 879, column 4): "unlanded" is not a valid Tier or MaybeEventTargetCharTitle.

At \interface\portrait_properties\00_portrait_properties.txt [1\5\modifier\OR\graphical_culture] (Line 862, column 5): "serb_southslavicgfx" is not a valid GraphicalCultureType or MaybeEventTargetChar.

At \interface\portrait_properties\00_portrait_properties.txt [1\5\modifier\graphical_culture] (Line 851, column 4): "croat_southslavicgfx" is not a valid GraphicalCultureType or MaybeEventTargetChar.

At \interface\portrait_properties\00_portrait_properties.txt [1\4\modifier\OR\graphical_culture] (Line 802, column 5): "serb_southslavicgfx" is not a valid GraphicalCultureType or MaybeEventTargetChar.

At \interface\portrait_properties\00_portrait_properties.txt [1\4\modifier\graphical_culture] (Line 791, column 4): "croat_southslavicgfx" is not a valid GraphicalCultureType or MaybeEventTargetChar.

At \interface\portrait_properties\00_portrait_properties.txt [1\2\modifier\OR\graphical_culture] (Line 718, column 5): "serb_southslavicgfx" is not a valid GraphicalCultureType or MaybeEventTargetChar.

At \interface\portrait_properties\00_portrait_properties.txt [1\2\modifier\graphical_culture] (Line 707, column 4): "croat_southslavicgfx" is not a valid GraphicalCultureType or MaybeEventTargetChar.

At \interface\portrait_properties\00_portrait_properties.txt [0\18\modifier\NOT\has_landed_title] (Line 480, column 12): "k_hellenic_pagan" is not a valid AnyTitle, MaybeEventTargetTitle, or No.

At \interface\portrait_properties\00_portrait_properties.txt [0\9\modifier\OR\has_landed_title] (Line 263, column 5): "k_hellenic_pagan" is not a valid AnyTitle, MaybeEventTargetTitle, or No.

Except for the two Hellenic ones, those feel like false positives?

[IhateTrains]

I need to check, but the slavic gfx issues may be real too.

[loup99]

I need to check, but the slavic gfx issues may be real.

We don't modify the 00_graphicalculturetype.txt though. It is not even in the mod.

[IhateTrains]

Maybe the k_hellenic_pagan references can be replaced with d_hellenic_pagan? Pontifex Maximus in vanilla is k_hellenic_pagan (is reformed hellenic), but in the mod Pontifex Maximus is d_hellenic_pagan (not reformed obviously).

[loup99]

Maybe the k_hellenic_pagan references can be replaced with d_hellenic_pagan? Pontifex Maximus in vanilla is k_hellenic_pagan (is reformed hellenic), but in the mod Pontifex Maximus is d_hellenic_pagan. (not reformed obviously).

Ok, will do.

[IhateTrains]

Yeah, the missing gfx look like errors in vanilla (unless they are somewhere in DLC files?).

[IhateTrains]

ACR:

• [x] Event celtic.300 is referenced twice in ACR_celtic_flavor_events, but it seems it's been removed on purpose
• [ ] dionysus.99 and dionysus.3 are missing and referenced in ACR_dionysus_events
• [x] ancrel.2103 is missing and referenced in ACR_hellenic_revival_events

[loup99]

The Dionysus events are not modified by us, so that is an ACR issue.

[Symmachus]

Duplicate localisation:
parthian culture and vanilla parthian bloodline. Now parthian culture appears as a ''Parthian blood''.