search

loup99 / WtWSMS

A Migrational Era Mod for CK2
https://forum.paradoxplaza.com/forum/index.php?forums/when-the-world-stopped-making-sense-mod.876/
Other
45 stars 33 forks source link

More work for spain #422

Closed Abian36 closed 4 years ago

loup99 commented 5 years ago

As I said, you should update the ChangeLog

IhateTrains commented 5 years ago

There are many bad merges which I haven't pointed out because they seem obvious.

loup99 commented 5 years ago

Has this been tested?

Abian36 commented 5 years ago

It has, everything works well, the only thing with putting the liege as its own liege is that it looks strange in the code but it causes no issues in game.

IhateTrains commented 5 years ago

It has, everything works well, the only thing with putting the liege as its own liege is that it looks strange in the code but it causes no issues in game.

It does cause issues though, when someone forgets to set the liege on change to holder from other realm.

Abian36 commented 5 years ago

Well, yes, but that is a very noticeable issue and I don't think I have found such