I noticed that the Errors Combine method always returns a ManyErrors, even if you're concatenating a single error and an Empty error. This violates the identity monoid laws (assuming we want to use == rather than Error.Is to determine Error equality, which may not be true) in addition to just feeling like a bug, at least to me.
Obviously, if this was intended or is fine, please disregard!
I noticed that the
ErrorsCombinemethod always returns aManyErrors, even if you're concatenating a single error and anEmptyerror. This violates the identity monoid laws (assuming we want to use==rather thanError.Isto determine Error equality, which may not be true) in addition to just feeling like a bug, at least to me.Obviously, if this was intended or is fine, please disregard!