louwrentius / fio-plot

Create charts from FIO storage benchmark tool output
BSD 3-Clause "New" or "Revised" License
370 stars 87 forks source link

bench-fio 1.1.1 can't handle multple iodepth config #106

Closed assange0 closed 1 year ago

assange0 commented 1 year ago

Here's my command:

bench-fio --target /mnt/nfs/v3/ --type directory --iodepth 1 8 --numjobs 1 --mode randread -s 1G -b 4k --runtime 60 --time-based --output ./results/nfsv3_9v1_tmp

And the log files only contains iodepth of 1, missing the iodepth of 8:

(fiovenv) root@vm-22a-22vn9:~/bench/fio# ll ./results/nfsv3_9v1_tmp/4k/
total 36
drwxr-xr-x 2 root root 4096 Mar 30 23:19 ./
drwxr-xr-x 3 root root 4096 Mar 30 23:18 ../
-rw-r--r-- 1 root root 6711 Mar 30 23:19 randread-1-1.json
-rw-r--r-- 1 root root 1289 Mar 30 23:19 randread-iodepth-1-numjobs-1_bw.1.log
-rw-r--r-- 1 root root 1371 Mar 30 23:19 randread-iodepth-1-numjobs-1_clat.1.log
-rw-r--r-- 1 root root 1230 Mar 30 23:19 randread-iodepth-1-numjobs-1_iops.1.log
-rw-r--r-- 1 root root 1371 Mar 30 23:19 randread-iodepth-1-numjobs-1_lat.1.log
-rw-r--r-- 1 root root 1251 Mar 30 23:19 randread-iodepth-1-numjobs-1_slat.1.log

While version 1.1.0 works fine.

louwrentius commented 1 year ago

That was a bit of an embarrassing bug, I could reproduce the issue and the fix seems to work properly.

assange0 commented 1 year ago

That was a bit of an embarrassing bug, I could reproduce the issue and the fix seems to work properly.

Thanks, test passed!