louwrentius / fio-plot

Create charts from FIO storage benchmark tool output
BSD 3-Clause "New" or "Revised" License
370 stars 87 forks source link

Version 1.1.3 reintroduces #106 #109

Closed willgorman closed 1 year ago

willgorman commented 1 year ago

With version 1.1.3 bench-fio appears to only be generating a fio test run for the first permutation of parameters rather than all of them. Version 1.1.2 does generate all permutations as expected. This looks like it may be the same issue that was originally fixed in #106

Command

Command: bench-fio --target . --type directory --size 1G --iodepth 1 16 --numjobs 1 2 --b 4k 16k --mode randrw --output example --rwmixread 90

1.1.3 Result

CleanShot 2023-04-10 at 15 58 03

1.1.2 Result

CleanShot 2023-04-10 at 16 01 55

louwrentius commented 1 year ago

I may have been making some mistakes with git, so I will investigate

louwrentius commented 1 year ago

Fix as implemented in version 1.0.4 seems to work. image

Plz let me know if there's any issue

willgorman commented 1 year ago

Thanks! I tried 1.1.4 and it's working the same as 1.1.2 👍