search

louwrentius / fio-plot

Create charts from FIO storage benchmark tool output
BSD 3-Clause "New" or "Revised" License
370 stars 87 forks source link

fix 134 rbdname crash #135

Closed ossarchitect closed 9 months ago

ossarchitect commented 9 months ago

Fixed issue 134 from louwrentius master branch checks.sh check_target_type function returned None which led to failure of bench-fio with TypeError. Fix was to return rbdname instead of None from check_target_type function. This correctly sets rbdname in the config dictionary in bench-fio. The fix tests ok, rbd benchmarking works.

louwrentius commented 9 months ago

Thanks a lot, I don't have a test ceph cluster anymore but I'll review it in the commming days 👍