search

louwrentius / fio-plot

Create charts from FIO storage benchmark tool output
BSD 3-Clause "New" or "Revised" License
370 stars 87 forks source link

Fixing same data added twice when scaling bandwidth logs #148

Closed triii10 closed 1 month ago

triii10 commented 2 months ago

Hi, I discovered an issue with y-axis units and the legends in line plot for bandwidth logs. There is a misplaced append happening in the for loop where values are scaled. The same dictionary gets pushed in the list twice for each op type (essentially twice for read and write).

Fixed it by moving the append to the correct level in the loop.

louwrentius commented 2 months ago

Thanks a lot! I'll test the fix on my test dataset this week.

Edit: sorry really busy may take longer

louwrentius commented 1 month ago

Thanks for your contribution!