louwrentius / fio-plot

Create charts from FIO storage benchmark tool output
BSD 3-Clause "New" or "Revised" License
370 stars 87 forks source link

TypeError: 'NoneType' object is not subscriptable #32

Closed rubin55 closed 4 years ago

rubin55 commented 4 years ago

After running the following bench_fio invocation:

./bench_fio --target /root/test --type directory --size 500MiB --output /root/out --iodepth 1 2 4 8 16 32 --numjobs 1 2 4 8 16 32 --rwmixread 50 --direct 1 --invalidate 1 --engine posixaio

Followed by this fio_plot command (using -L to request the 3D graph):

./fio_plot  -i ../../edge/  -L -r randread -T Test

I'm getting the following error from fio_plot:

Traceback (most recent call last):
  File "./fio_plot", line 180, in <module>
    main()
  File "./fio_plot", line 147, in main
    run_preflight_checks(settings)
  File "./fio_plot", line 123, in run_preflight_checks
    if settings['type'][0] not in ['iops', 'lat']:
TypeError: 'NoneType' object is not subscriptable
rubin55 commented 4 years ago

I just discovered you can/have-to also specify either iops or lat with the -t option.

louwrentius commented 4 years ago

I've improved the error handling and it now explains to you what must be done if you specify -L without -t. Thanks for your report.