louwrentius / fio-plot

Create charts from FIO storage benchmark tool output
BSD 3-Clause "New" or "Revised" License
370 stars 87 forks source link

made the -C chart more flexible with bw support #58

Open bhelm opened 3 years ago

bhelm commented 3 years ago

I have tried to make the C Chart more flexible by respecting the -t option; its now possible to do "-t bw" (for bw-only graph) or "-t bw lat" (for the combined graph with bw instread of iops). "-t iops" for iops-only is also possible.

maybe you like it and merge it :)

I have generated the graphs at my blog post about raid5 and raid10 bencharks using this version.

louwrentius commented 3 years ago

Wow, thanks for the patch! I'll test it with some local examples I have here.

datadict["bw_series_raw"].append(record["bw"]/1000)

I think that may need to be 1024 (MiB vs MB) but I will check/verify

bhelm commented 3 years ago

datadict["bw_series_raw"].append(record["bw"]/1000)

I think that may need to be 1024 (MiB vs MB) but I will check/verify

yeah you are right. should i change it or will you do with your review?

Wow, thanks for the patch! I'll test it with some local examples I have here.

I have to thank for creating this tool!

Maybe you can generate a matching graph for the Readme.md.

louwrentius commented 3 years ago

Thank you, I will make the changes and update the readme with an example.

With your patch, it is now possible to omit the latency in the compare graph but the axis seem to remain, I'll tackle that as well or leave it as it is (cosmetic issue I can live with).

louwrentius commented 3 years ago

I have to dig into that 1000/1024 stuff, because that needs to be done through the scaling function, not hard-coded with 1000/1024. It may take a bit before I can merge. I've not touched this code for a while.

devillove084 commented 2 years ago

I used this pr and drew a histogram of the relationship between bandwidth and block size. I think this pr is very necessary. The expression of this relationship is very important in my project. ssr