louwrentius / fio-plot

Create charts from FIO storage benchmark tool output
BSD 3-Clause "New" or "Revised" License
370 stars 87 forks source link

--max-iops and --max-latency options don't work for 2D bar chart style graphs (-C and -l) #71

Closed jsrolon closed 1 year ago

jsrolon commented 2 years ago

Hello, I am trying to get multiple comparison graphs to have the same ranges on their y-axes. I am plotting one comparison graph per numjobs value. I thought that I could accomplish this by using --max-iops and --max-latency, as in:

fio-plot -i libaio uio_pci_generic vfio-pci -T "Dell P4800X SSD" -C -r randrw -f write --numjobs 16 --max-lat 40 --max-iops 300000

Since my latency values range from 9 to 32 us or so in all cases. What happens now is that every graph has its own y-axis value range, making it hard to do comparisons between numjob values hard with quick glances.

Any command line options for this, or should I modify the plotting code?

Thanks!

louwrentius commented 2 years ago

Hi, I’m not sure exactly what is going on. Could you also share the files so I can reproduce this? Can share them by mail if you want (louwrentius at gmail dot com)

With regards

On 10 Feb 2022, at 04:36, Sebastian Rolon @.***> wrote:

 Hello, I am trying to get multiple comparison graphs to have the same ranges on their y-axes. I am plotting one comparison graph per numjobs value. I thought that I could accomplish this by using --max-iops and --max-latency, as in:

fio-plot -i libaio uio_pci_generic vfio-pci -T "Dell P4800X SSD" -C -r randrw -f write --numjobs 16 --max-lat 40 --max-iops 300000 Since my latency values range from 9 to 32 us or so in all cases. What happens now is that every graph has its own y-axis value range, making it hard to do comparisons between numjob values hard with quick glances.

Any command line options for this, or should I modify the plotting code?

Thanks!

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.

louwrentius commented 2 years ago

The answer to your problem is for 99% due either bad documentation or me not implementing things consistently.

I've grepped through the code and the --max-lat --max-iops parameters don't work for this graph type (2d bar chart), it was only implemented for 3D bar charts and -g style graphs.

louwrentius commented 1 year ago

--max-lat and --max-iops now work for this graph type.