search

louwrentius / fio-plot

Create charts from FIO storage benchmark tool output
BSD 3-Clause "New" or "Revised" License
370 stars 87 forks source link

Filter JSON files based on internal keys #72

Closed jsrolon closed 2 years ago

jsrolon commented 2 years ago

A very simple solution to the issue opened in #70 , the filtering function that previously used filenames now opens the json file and checks for some basic keys that should be present if the output was created by fio.

louwrentius commented 2 years ago

Holy shit, I think you made my day, thanks so much for this effort. I run a bunch of test scripts creating various different graphs and no errors showed up.

In the comments you wrote that it is a bit slow, to read each JSON, but my test set contains hundreds of JSON files and although I didn't benchmark it, it's still quite fast, so I don't think there's any problem.

Again thanks!