louwrentius / showtools

Shows detailed disk or network device information
BSD 3-Clause "New" or "Revised" License
121 stars 17 forks source link

No support for NVMe drives #15

Open hyperbart opened 2 years ago

hyperbart commented 2 years ago

Recently I added an NVMe drive to one of my servers. When running showtools it only shows: Dev GB

to be expected?

louwrentius commented 2 years ago

Yes, I have no NVMe hardware to test with

On 1 Oct 2021, at 15:58, hyperbart @.***> wrote:

 Recently I added an NVMe drive to one of my servers. When running showtools it only shows: Dev GB

to be expected?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

louwrentius commented 2 years ago

What is the /dev/ device name? And /dev/disk/by-id ?

hyperbart commented 2 years ago
lrwxrwxrwx 1 root root 13 Sep 28 09:32 /dev/disk/by-id/nvme-eui.00000000000000000026b768501484d5 -> ../../nvme0n1
lrwxrwxrwx 1 root root 15 Sep 28 09:32 /dev/disk/by-id/nvme-eui.00000000000000000026b768501484d5-part1 -> ../../nvme0n1p1
lrwxrwxrwx 1 root root 13 Sep 28 09:32 /dev/disk/by-id/nvme-KINGSTON_SA2000M81000G_50026B768501484D -> ../../nvme0n1
lrwxrwxrwx 1 root root 15 Sep 28 09:32 /dev/disk/by-id/nvme-KINGSTON_SA2000M81000G_50026B768501484D-part1 -> ../../nvme0n1p1

root@nas:~# ls -lah /dev/nvm*
crw------- 1 root root 241, 0 Sep 28 09:32 /dev/nvme0
brw-rw---- 1 root disk 259, 0 Sep 28 09:32 /dev/nvme0n1
brw-rw---- 1 root disk 259, 2 Sep 28 09:32 /dev/nvme0n1p1
louwrentius commented 2 years ago

Would you mind sending me the output of /sys/block ? This virtual file is used as the single source of truth for storage on the system from the perspective of the show tool.

hyperbart commented 2 years ago
total 0
drwxr-xr-x  2 root root 0 Oct 11 12:08 .
dr-xr-xr-x 13 root root 0 Sep 13 18:46 ..
lrwxrwxrwx  1 root root 0 Oct 11 12:09 loop0 -> ../devices/virtual/block/loop0
lrwxrwxrwx  1 root root 0 Oct 11 12:09 loop1 -> ../devices/virtual/block/loop1
lrwxrwxrwx  1 root root 0 Oct 11 12:09 loop2 -> ../devices/virtual/block/loop2
lrwxrwxrwx  1 root root 0 Oct 11 12:09 loop3 -> ../devices/virtual/block/loop3
lrwxrwxrwx  1 root root 0 Oct 11 12:09 loop4 -> ../devices/virtual/block/loop4
lrwxrwxrwx  1 root root 0 Oct 11 12:09 loop5 -> ../devices/virtual/block/loop5
lrwxrwxrwx  1 root root 0 Oct 11 12:09 loop6 -> ../devices/virtual/block/loop6
lrwxrwxrwx  1 root root 0 Oct 11 12:09 loop7 -> ../devices/virtual/block/loop7
lrwxrwxrwx  1 root root 0 Oct 11 12:09 loop8 -> ../devices/virtual/block/loop8
lrwxrwxrwx  1 root root 0 Oct 11 12:09 nvme0n1 -> ../devices/pci0000:00/0000:00:1b.4/0000:03:00.0/nvme/nvme0/nvme0n1
lrwxrwxrwx  1 root root 0 Oct 11 12:09 sda -> ../devices/pci0000:00/0000:00:1d.0/0000:04:00.0/host7/port-7:0/end_device-7:0/target7:0:0/7:0:0:0/block/sda
lrwxrwxrwx  1 root root 0 Oct 11 12:09 sdb -> ../devices/pci0000:00/0000:00:1d.0/0000:04:00.0/host7/port-7:1/end_device-7:1/target7:0:1/7:0:1:0/block/sdb
lrwxrwxrwx  1 root root 0 Oct 11 12:09 sdc -> ../devices/pci0000:00/0000:00:1d.0/0000:04:00.0/host7/port-7:2/end_device-7:2/target7:0:2/7:0:2:0/block/sdc
lrwxrwxrwx  1 root root 0 Oct 11 12:09 sdd -> ../devices/pci0000:00/0000:00:1d.0/0000:04:00.0/host7/port-7:3/end_device-7:3/target7:0:3/7:0:3:0/block/sdd
lrwxrwxrwx  1 root root 0 Oct 11 12:09 sde -> ../devices/pci0000:00/0000:00:1d.0/0000:04:00.0/host7/port-7:4/end_device-7:4/target7:0:4/7:0:4:0/block/sde
lrwxrwxrwx  1 root root 0 Oct 11 12:09 sdg -> ../devices/pci0000:00/0000:00:17.0/ata3/host3/target3:0:0/3:0:0:0/block/sdg
lrwxrwxrwx  1 root root 0 Oct 11 12:09 sdh -> ../devices/pci0000:00/0000:00:17.0/ata6/host6/target6:0:0/6:0:0:0/block/sdh
louwrentius commented 2 years ago

Did I ever resolve this issue for you?

hyperbart commented 2 years ago

Did I ever resolve this issue for you?

I just did a git pull (in the folder where my showtools is stored):

root@nas:~/showtools# git pull
remote: Enumerating objects: 12, done.
remote: Counting objects: 100% (12/12), done.
remote: Compressing objects: 100% (9/9), done.
remote: Total 12 (delta 6), reused 5 (delta 3), pack-reused 0
Unpacking objects: 100% (12/12), 8.86 KiB | 604.00 KiB/s, done.
From https://github.com/louwrentius/showtools
   64b3cb4..66b46b6  master     -> origin/master
Updating 64b3cb4..66b46b6
Fast-forward
 show | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

But when executing a showtools is still does not show model, sn, firmware etc Temp, hours, ps, rs, rse, crc and park are showing "?", which is okay I guess for some things at least.

louwrentius commented 2 years ago

I misunderstood the issue. I need to add nvme-cli support. Thanks for the update, I'll see if I can fix this without access to an NVME drive.

louwrentius commented 9 months ago

I've just committed a new showtools version to master, that parses JSON output of smartctl which should be more reliable.

I don't know if you have time to test it but feedback would be appreciated.

I noticed that smartmontools supports NVME from versino 6.5 so if it's not working that may be something to check. https://www.smartmontools.org/wiki/NVMe_Support

If there is something not ok, could you share the json output of: smartctl -a -j /dev/nvmexxx