search

lovac42 / Fanfare

Addon: Gamification, feedback, and reinforcement
GNU General Public License v3.0
8 stars 4 forks source link

Fix for recent Anki 2.1 versions #18

Closed abdnh closed 2 years ago

abdnh commented 2 years ago

This is a quick and dirty fix to make the add-on work on recent Anki versions. Confirmed to work with .49 and .50

At least image display and audio playback work. Some other features may need further changes.

Maybe it's time to drop 2.0 support and simplify the code.

A packaged build of the changes is available here: https://github.com/abdnh/anki-fanfare/releases/tag/v0.2.0

lovac42 commented 2 years ago

Thanks, I had no idea this still works for QT6. But this is a bit of a hacky solution that doesn't address the security problems (see Kitten Rewards). Also, there should be some runtime error as well depending on the platform as numerous changes had been made to Anki's audio and template modules.

Most of all, I simply don't want to support for QT5 and QT6 due to the high lag time, image alignment, performance and addon conflicts. First impressions matter a lot here. It's like playing a bootleg game that semi-freezes and destroys the whole user experience. I would rather wait for Anki to switch to Electron before looking into it again.

abdnh commented 2 years ago

I took a look at Kitten Rewards. I'm still not sure about the security problems, but I guess it has something to do with path redirecting and this change in Anki? I agree that it's a hacky solution. I will look more into fixing the breakages properly (maybe even starting a full, independent rewrite).

lovac42 commented 2 years ago

Correct, I prefer not going into details on sensitive issues. As I already stated on the release page, it costs more development time to upgrade this rather than a rewrite targeting QT6 and later versions. But do as you like.

I am fine if you want to Fork this or rewrite your own. Just change the name of the project. That will avoid any confusions as to who is the author: the one responsible for damages, the one to lynch. Some users share these by USB not knowing where the original was downloaded from.