lovac42 / ReMemorize

Addon: reschedule current reviewer card and siblings
GNU General Public License v3.0
13 stars 2 forks source link

Why does the ease of changed cards change to 130%? #2

Closed cjdduarte closed 6 years ago

cjdduarte commented 6 years ago

I noticed that the cards changed by its addon, has the facility changed to 130%. Because?

image

cjdduarte commented 6 years ago

I've analyzed your code and made this change. I noticed that the new cards got the initial value of 0 (zero) and after the first study, it changed to 130%.

This modification answered me. See if something should not be done about it.

image

lovac42 commented 6 years ago

Do you have another addon causing this? Isolate the addons and test them again, this couldn't have been cause by my addon.

cjdduarte commented 6 years ago

I'll do a test and I'll come back.

lovac42 commented 6 years ago

If you remove my addon, it's still set to 130. So this may be what happened. Anki initializes the new cards to 0, and sets it to 2500 after you first graded it. So if you reschedule a new card, it skips the initialization process and the next time it comes around, Anki see's 0 as invalid changes it to 1300 which is the smallest number allowed. In your picture, is the 0% and 250% the same card as the 130%? It shouldn't change the 250% to 130% at all.

cjdduarte commented 6 years ago

The error occurs when I use a negative number.

I tested in a new installation:

image

I created a new card:

image

In the first study, I used its addon and used the value "-1"

image

Here are the new values:

image

To test the "future", I'm using the "runasdate" application and disable the internet.

image

Now I will use the card and mark "Good", and it will reschedule for 2 days.

image

image

The addon did everything correctly, however the ease was up to 130%.

image

Would not it be the case that your addon has placed 250% if the card is new (0%) and used the negative value?

lovac42 commented 6 years ago

Yes, see my comments above yours. In your picture, is the 0% and 250% the same card as the 130%? It shouldn't change the 250% to 130% at all.

I will add some code to initialize the card. Here's the new changes. https://github.com/lovac42/ReMemorize/blob/initNewCards/src/rememorize/utils.py

cjdduarte commented 6 years ago

Thank you, I believe it will work. I will do the final test when you publish.

An observation. I use the default value (250%), but if another user uses a different value, I think the most correct place to get the information would be here:

image

But the way you did, you'll answer me.

lovac42 commented 6 years ago

You can test them for me now by copying and overwriting your local copy. But I do believe this will solve the issue. Thanks for bringing it to my attention.

cjdduarte commented 6 years ago

It worked.

image

cjdduarte commented 6 years ago

Sorry, I took the wrong test.

cjdduarte commented 6 years ago

I tested it with your new code and it did not work. I used the value "-40" and the card continued 0%

lovac42 commented 6 years ago

yeah sorry forgot about negative values. This will do it. https://github.com/lovac42/ReMemorize/blob/initNewCards/src/rememorize/rememorize.py

cjdduarte commented 6 years ago

It's OK. Thank you.

cjdduarte commented 6 years ago

Tanks