lovasoa / SQLpage

SQL-only webapp builder, empowering data analysts to build websites and applications quickly
https://sql.ophir.dev
MIT License
882 stars 62 forks source link

Add `data-bs-theme="light"` Attribute for Consistent Theme Handling in CSS #369

Closed amrutadotorg closed 1 month ago

amrutadotorg commented 1 month ago

Issue Description:

Hi,

It would be much easier to work with the CSS if we could add the data-bs-theme="light" attribute in the same way the data-bs-theme="dark" attribute has been added.

Current Implementation:

Proposed Change:

We should also make similar changes for other layouts to ensure consistency.

Benefits:

Once this change is implemented, accessing both themes in the CSS would be much easier. For example:

body[data-bs-theme="dark"] #headline strong {
  background-color: #00E5FF; /* Bright cyan highlight background */
  color: #1C2833; /* Dark text for contrast */
  font-weight: bold;
  padding: 2px 4px; /* Optional: add padding to make the highlight more noticeable */
  border-radius: 3px; /* Optional: add border-radius for rounded corners */
}

This will allow for more efficient and maintainable theme-specific styling.

Thank you!

lovasoa commented 1 month ago

You can use the not attribute in CSS. I don't think you need more...