search

lovasoa / SQLpage

SQL-only webapp builder, empowering data analysts to build websites and applications quickly
https://sql.ophir.dev
MIT License
880 stars 62 forks source link

Shell navbar menu extension #430

Closed pchemguy closed 1 week ago

pchemguy commented 1 week ago

This modified "shell" component extends menu functionality (primarily adds support for icons in menu items and styling menu items as buttons). This pull request also contains a sample hybrid menu demo file menu_demo.sql.

pchemguy commented 1 week ago

I have updated this pull request to include all changes made in "Parse JSON menu_item for SQLite and skip blank items", so that this pull request could be merged without conflicts after the other one is accepted. Please take a look at the extended "shell" component and accept the pull request, if you think it is OK, or let me know of any issues.

pchemguy commented 1 week ago

I have resolved current conflicts.

lovasoa commented 1 week ago

Thanks for the PR !

There are multiple things here.

I'm still not convinced by the looks of this

image

But I clearly see the interest of fixed_top for instance.

Can you open distinct pull requests ? This will make it easier to merge what can be merged now, and to discuss what still needs to be discussed.

pchemguy commented 1 week ago

To clarify, the three new PRs are just that (parts of this PR).

lovasoa commented 1 week ago

Great, I already merged the sticky top menus. I'm closing this one in favor of the others, then