search

lovasoa / SQLpage

Fast SQL-only data application builder. Automatically build a UI on top of SQL queries.
https://sql.datapage.app
MIT License
1.49k stars 81 forks source link

Environmental variable naming convention proposal #44

Closed f8dca closed 1 year ago

f8dca commented 1 year ago

I think the environmental variable names for SQLPage are way to generic and prone for collision with other applications.

Maybe sqlpage_envname format would be a better choice. Another benefit of this approach would be that when the variables listed they would be grouped together by default.

lovasoa commented 1 year ago

I'm agree with that for things that are specific to SQLPage. Would you want to make a pull request ? It should be easy to implement because we use a library for configuration that supports automatically adding prefixes.

However, at least for DATABASE_URL, I would be in favor of keeping it as is (or at least keeping it as an alternative to SQLPAGE_DATABASE_URL), since it's somewhat of a global generic convention in a lot of frameworks, and applications.

lovasoa commented 1 year ago

I just pushed v0.10.0 which implements that