search

lovasoa / marshmallow_dataclass

Automatic generation of marshmallow schemas from dataclasses.
https://lovasoa.github.io/marshmallow_dataclass/html/marshmallow_dataclass.html
MIT License
456 stars 78 forks source link

Issues with typeguard package v3 #234

Closed jleben closed 1 year ago

jleben commented 1 year ago

typeguard version 3 does not have the argname argument to check_type(), raising an exception in marshmallow_dataclass.

Moreover, the version of typeguard is not constrained in setup.py, causing a silent upgrade of typeguard in projects that use marshmallow_dataclass even when those projects fully constrain the version of marshmallow_dataclass, which breaks those projects in a surprising way. It caused me an hour to debug one of my projects. The version of typeguard should have at least the major version number contrained.

anzhurov commented 1 year ago

Our project also facing that issue.

Please, fix the places of using typeguard.check_type and also strictly set typeguard version to avoid such situation in future.

Please, do that asap

dairiki commented 1 year ago

You all are kind of pushy! Realize that we all work for free here.

If you can check out/review #235 to make sure that fixes things for you, that would be great.

dairiki commented 1 year ago

Hopefully fixed as of marshmallow_dataclass==8.5.12.