search

lovasoa / marshmallow_dataclass

Automatic generation of marshmallow schemas from dataclasses.
https://lovasoa.github.io/marshmallow_dataclass/html/marshmallow_dataclass.html
MIT License
456 stars 78 forks source link

Add Annotated support #257

Closed mvanderlee closed 2 months ago

mvanderlee commented 6 months ago

Fixes #256

Moving away from NewType and instead add Annotated support.

mivade commented 6 months ago

I would recommend importing Annotated from typing_extensions for Python 3.8 support (at least for as long as that continues receiving security updates).

mvanderlee commented 5 months ago

Rebased, and retested.

mvanderlee commented 5 months ago

@lovasoa @dairiki Any idea when you'll have time to review this? I'd like to see this merged so I can rebase and finalize the generic dataclass PR #259

mvanderlee commented 2 months ago

I apologize for the delay. (Life has been crazy.)

The feature addition is a good one, I think. (Thank you!) And other than some style nits, I think it looks fine.

I think the addition of tox test configuration is long overdue. Ideally, it would be a separate PR, but since it's in here, already, I'm fine leaving it here. I do have a few comments about that.

I haven't had time since either, so I get it. Thank you for taking the time to review it!

mvanderlee commented 2 months ago

I think I've resolved all issues. The PR is ready for review again.

mvanderlee commented 2 months ago

I've removed tox.ini from this PR.

dairiki commented 2 months ago

Merged. Thank you, @mvanderlee !

I tried to make a new PyPI release (8.7.0) but #270 happened.

dairiki commented 2 months ago

Now released in 8.7.0.