search

lovasoa / marshmallow_dataclass

Automatic generation of marshmallow schemas from dataclasses.
https://lovasoa.github.io/marshmallow_dataclass/html/marshmallow_dataclass.html
MIT License
456 stars 78 forks source link

Remove obsolete typeguard checks #274

Open epenet opened 2 months ago

epenet commented 2 months ago

Follow-up to #263

dairiki commented 2 months ago

@lovasoa @epenet I am currently traveling and dealing with family medical issues. I can probably find some time to look at this in the next couple of days, but nothing is certain.

I think this looks fine. The one thing that pops out on initial glance is that we might want to adjust our pins

https://github.com/lovasoa/marshmallow_dataclass/blob/4edbfb44307b4df91261c75175d6916acd88f0be/setup.py#L49-L55

I think we might want to adjust these to typeguard ~= 4.0 (to address #272) . And maybe typing-inspect >= 0.9.0 (semver does not apply to 0.* versions).

epenet commented 2 months ago

I created a separate PR to fix #272 See #273