love2d-community / love-api

The whole LÖVE wiki in a Lua table.
http://love2d-community.github.io/love-api/
299 stars 46 forks source link

Various functions, enums, and type modification. #89

Closed MikuAuahDark closed 3 years ago

MikuAuahDark commented 4 years ago

This is somewhat a big changes. These changes were made when I was making Teal type definitions for LOVE, but I think it's useful to have some of the changes to upstream. Feel free to review and add comment, but I'll keep it in draft state until I completed it.

Progress:

MikuAuahDark commented 4 years ago

There are some problems

  1. Some description for PixelFormat enum needs better description.
  2. The HTML generator doesn't see love.font module for some reason.
hahawoo commented 3 years ago

Thank you! :) I left love.font out of the HTML generator because, as far as I knew at the time, these functions were used internally in LOVE's code but there wasn't a reason for a LOVE user to use them instead of love.graphics.newFont or love.graphics.newImageFont, but please let me know if I was mistaken!

MikuAuahDark commented 3 years ago

Looks like http://love2d-community.github.io/love-api/ is not updated yet after this merge.

hahawoo commented 3 years ago

Sorry @MikuAuahDark, I somehow didn't see your comment unti now. This project doesn't really seem to have an active maintainer, and I don't want to actively maintain it. Would you like to, or know anyone who would? :) I think updating the HTML page is simply a matter of running html-generator.lua and uploading the resulting page. And/or, would you like to maintain loveref.github.io? It is basically the same but with a URL and a design that I prefer.

MikuAuahDark commented 3 years ago

Actually I have write access to this repo, but since I don't want to suddenly push lots of change without any discussion first, I made it as PR instead.

About loveref.github.io, I personally prefer the love2d-community.github.io/love-api style, although I think some text are simply too small, but that can be fixed by increasing the size of the text. I think automating the updates with GitHub Actions is possible, but I can't promise anything for the next 2 weeks.

hahawoo commented 3 years ago

Awesome, well if you find a way to automate the updates I'll do the same thing with loveref.github.io :)

Regarding making the text bigger, you might want to check out and merge PR #80

MikuAuahDark commented 3 years ago

After checking the repo, why doesn't this used? https://github.com/love2d-community/love-api/blob/master/.travis/push.sh

Anyway we may able to discuss about automating further in Discord.

hahawoo commented 3 years ago

I'm not sure, I believe @rm-code and @daviel set this up.

While I can't say that I'm the "owner" of this repo (@rm-code again did the work for this, which I'm grateful for), you have my blessing (for what it's worth) @MikuAuahDark to automate and otherwise improve this project in any way you see fit (as does anyone else with write access to this repo).

MikuAuahDark commented 3 years ago

Well, I guess I'll wait for their replies first then. I don't want to mess up anything.