search

love2d-community / splashes

A collection of splash screens for LÖVE
Other
76 stars 18 forks source link

Fix Shader for OpenGL ES 2.0 feature set #11

Closed s-ol closed 8 years ago

s-ol commented 8 years ago

This is what currently causes the issues with the gh-pages /love.js builds.

rm-code commented 8 years ago

I'll see what I can do. Wanted to get back into GLSL coding anyway.

rm-code commented 8 years ago

Welp ... @TannerRogalsky was faster :D

JanWerder commented 8 years ago

I still seems to crash

rm-code commented 8 years ago

Yup, same here.

TannerRogalsky commented 8 years ago

@JanWerder @rm-code Please read through that PR. There is another issue.

TannerRogalsky commented 8 years ago

I'm going to provide a 'compatibility' build going forward to avoid issues like this. Performance and file size take a hit but it should be easier to work with. https://github.com/TannerRogalsky/love.js/tree/master/release-compatibility

s-ol commented 8 years ago

Can someone verify that love2d-community.github.io/splashes does now work with the compat love.js?

TannerRogalsky commented 8 years ago

@S0lll0s I'm getting the following error:

Error: [string "boot.lua"]:432: No code to run
love.js:1 Your game might be packaged incorrectly
love.js:1 Make sure main.lua is at the top level of the zip
love.js:1 stack traceback:
love.js:1   (tail call): ?
love.js:1   [C]: in function 'error'
love.js:1   [string "boot.lua"]:432: in function <[string "boot.lua"]:274>
love.js:1   [C]: in function 'xpcall'
s-ol commented 8 years ago

hm, for some reason love.js completely wrecks my browser. Can't even debug this situation right now until I get back home in 2-3 weeks :/

slime73 commented 8 years ago

don't rely in smoothstep

smoothstep works fine in OpenGL ES 2's shading language.

TannerRogalsky commented 8 years ago

@slime73 https://github.com/love2d-community/splashes/pull/12#issuecomment-186835296 :D :D

s-ol commented 8 years ago

So think this is done then?