search

love2d-community / splashes

A collection of splash screens for LÖVE
Other
76 stars 18 forks source link

luacheck sanity changes #17

Closed qoh closed 8 years ago

qoh commented 8 years ago

Since luacheck was complaining about them when I was looking over the code, I've gone ahead and removed some global variables and fixed local variables being shadowed :+1: (except for timer.lua, since I think that's library code?).

I've also changed tween_and_wait(dur, pen, easing) to actually use the easing argument, rather than how it was previously ignoring it and using a constant "in-quad". This function is actually called with different easings (immediately below it) so this should be making a difference in the animations, but I'm not really noticing one. Make sure I'm not unintentionally messing it up by doing that. :smile:

s-ol commented 8 years ago

Oh, good catch on the easing thing. Maybe squash everything together in one nice commit except for that fix?

I can do that too though if you don't know the git-fu :)

qoh commented 8 years ago

@s-ol I wasn't able to get the easing fix into a different commit (reordering in rebase didn't quite work), so if you want to do that, go ahead. I did get it all into one commit though.

josefnpat commented 8 years ago

:+1: nice cleanup