search

love2d / love-android

Android build setup for LÖVE.
https://love2d.org
Other
200 stars 70 forks source link

Add DocumentsProvider for access to external stroage #230

Closed Vixeliz closed 2 years ago

Vixeliz commented 2 years ago

I was able to test and it appears all the functions are working. The file this is based off is https://github.com/android/storage-samples/tree/main/StorageProvider/Application/src/main/java/com/example/android/storageprovider. With minor tweaks it works great for this basically just making it work with local storage in mind instead of cloud and adapting it to the love icons and such. Simple stuff. Should work on any android version love-android supports.

Vixeliz commented 2 years ago

Don't merge yet slight problem when using documentprovider from other applications

Vixeliz commented 2 years ago

Should be fixed worked when I tested

Vixeliz commented 2 years ago

I forgot to add a notice of changes below the license not sure if you want to just do that or if I should? According to sources online you just have to note substantial changes so I think just putting "changed to work better with local storage in mind would work" not sure though

Vixeliz commented 2 years ago

Some cleanup/fixes but still not ready to be merged this is a lot closer to the final product though. It technically works but I'm unhappy with one of the bugs

Vixeliz commented 2 years ago

Ready to merge bug isn't fault of our side happens due to the file manager I was testing with. One other "bug" is with an application called acode when creating a file or folder it'll throw an error but still work. It doesn't happen with termux's documentprovider though. However I don't think it's actually due to the documentprovider itself after trying out logcat and doing some research it appears to be something with handling contenturis? But luckily it still functions so I think it's out of the scope for this pr

Vixeliz commented 2 years ago

I'll get all these changes cleaned up in a few here.