Abstract configurable values to gradle.properties

love2d / love-android

Android build setup for LÖVE.

https://love2d.org

Other

200 stars 70 forks source link

Abstract configurable values to gradle.properties #243

Closed flamendless closed 1 year ago

MikuAuahDark commented 1 year ago

https://github.com/love2d/love-android/actions/runs/4072979689/jobs/7016399946#step:4:4575

Attribute meta-data#com.google.android.gms.ads.APPLICATION_ID@value at AndroidManifest.xml:42:9-42 requires a placeholder substitution but no value for <APPLICATION_ID> is provided.

Looks like applicationId can't be variable afterall?

flamendless commented 1 year ago

@MikuAuahDark I've pushed the fix.

MikuAuahDark commented 1 year ago

Thanks. Merged.

flamendless commented 1 year ago

Fix https://github.com/love2d/love-android/pull/244