love2d / love

LÖVE is an awesome 2D game framework for Lua.
https://love2d.org
Other
4.84k stars 388 forks source link

Decoding PNG image throws an error in 11.4 #1774

Closed gustavostuff closed 2 years ago

gustavostuff commented 2 years ago

I was happily updating the game I'm workin on (on a Mac, using 11.3), I pushed the code to NotABug, pulled it in my other laptop (Manjaro Linux, LÖVE 11.4) and then I get this issue. I'm not doing anything fishy at this point, just opening a bunch of png images, and this error pops up with the first call to love.graphics.newImage()

Captura-de-pantalla-2022-02-09-22-23-14.png

this is the line that fails, just for reference: images.popImg = love.graphics.newImage(imgDir .. 'pop.png')

MikuAuahDark commented 2 years ago

Please read from here https://github.com/love2d/love/issues/1727#issuecomment-944993952

It's not LOVE mistake, but this start seem to be more common, so I'll keep this open for a while.

gustavostuff commented 2 years ago

@MikuAuahDark thanks. Added a comment in there.

MikuAuahDark commented 2 years ago

Oh I meant you should comment it out here instead, but whatever.

thegrb93 commented 2 years ago

I've found GIMP will cause this unless I uncheck everything in the advanced section of the save png menu.

gustavostuff commented 2 years ago

@thegrb93 last version of gimp? I ask because I saved many images using Gimp on Mac (not the latest version and has serious slowness issues) but I also use Gimp in linux (latest Gimp).

thegrb93 commented 2 years ago

@tavuntu 2.10.8. Looks like latest is 2.10.30 so I could try updating.

thegrb93 commented 2 years ago

@tavuntu looks it's fixed in the latest gimp version

gustavostuff commented 2 years ago

Awesome, thanks, so it seems this was a Gimp issue after all (or one of the libraries it uses). That's some good info.

MikuAuahDark commented 2 years ago

According to https://gitlab.gnome.org/GNOME/gimp/-/issues/2111, it seems to be fixed in GIMP 2.10.24 or later.