Incorrect bitwise opcode interpretation (mostly affecting mov1 opcodes) in disassembly

loveemu / vgm-disasm

Disassemblies of Various Video Game Music Drivers

46 stars 8 forks source link

Incorrect bitwise opcode interpretation (mostly affecting mov1 opcodes) in disassembly #2

Open KungFuFurby opened 3 years ago

KungFuFurby commented 3 years ago

This only affects the way the bits were processed in the original disassembly, and does not affect the number of bytes read. I only actually looked up the mov1 series of opcodes, but these disassembles are affected:

Chrono Trigger
F-Zero
Live A Live
Final Fantasy 5
Final Fantasy 6
Final Fantasy Mystic Quest
Front Mission
Pilotwings
Romancing SaGa
Seiken Densetsu 2/Secret of Mana
Super Bomberman
Super Bomberman 3
Super Mario All-Stars
Super Mario RPG
Tetris Attack

loveemu commented 3 years ago

Thank you for reporting. This happened because of an old bug in spcdas, I suppose. https://github.com/gocha/spcdas/commit/a5aad40628920c848c996e5da1832923ea814952

I can't determine the exact list of disassemblies that affected by the bug. Old disassemblies can have this problem.