F-Droid

[linsui]

Can I package this app for F-Droid?

[lovegaoshi]

sure thing, appreciate the work!

On Wed, Jun 26, 2024, 8:22 AM linsui @.***> wrote:

Can I package this app for F-Droid?

— Reply to this email directly, view it on GitHub https://github.com/lovegaoshi/azusa-player-mobile/issues/502, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZMOVVWN2OIMJD67C675MSDZJLMCRAVCNFSM6AAAAABJ6ED7O2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGM3TKNRUGY4TEOI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

[linsui]

I'll have a try. :)

[linsui]

The build failed without a clear error. https://gitlab.com/linsui/fdroiddata/-/jobs/7199886552 Any idea?

[lovegaoshi]

is there a way to get the output of node /home/vagrant/build/com.noxplay.noxplayer/node_modules/@react-native-community/cli/build/bin.js config? im seeing a json format of some info of packages used.

[linsui]

error Failed to build the app: No package name found. We couldn't parse the namespace from neither your build.gradle[.kts] file at null nor your package in the AndroidManifest at /home/vagrant/build/com.noxplay.noxplayer/node_modules/react-native-blob-util/android/src/main/AndroidManifest.xml.

[lovegaoshi]

i have no idea:S does this patch fix? https://github.com/lovegaoshi/azusa-player-mobile/commit/320f920b76357f1bd7990f9d4ae5718accdacb23 from branch https://github.com/lovegaoshi/azusa-player-mobile/tree/dev-fdroid

[linsui]

You have some good ideas, it works! :) https://gitlab.com/linsui/fdroiddata/-/jobs/7210653702 Now we need to build those abis one by one. Can you add something like https://github.com/SwissBitcoinPay/app/blob/main/android/app/build.gradle#L87C5-L87C29 and https://github.com/SwissBitcoinPay/app/blob/main/android/app/build.gradle#L143?

[lovegaoshi]

i believe its already split https://github.com/lovegaoshi/azusa-player-mobile/blob/320f920b76357f1bd7990f9d4ae5718accdacb23/android/app/build.gradle#L88

and added the version code u mentioned https://github.com/lovegaoshi/azusa-player-mobile/blob/b86c815b549d6b3de61ce4e5c85f623a8cabf009/android/app/build.gradle#L131

[linsui]

and added the version code u mentioned

Thanks!

i believe its already split

Yep, but F-Droid needs to build the apks one by one so we need to set the abi for every build. I can patch the file but it would be better if I can set the abi easily. :)

[lovegaoshi]

sry im not understanding here; the only diff i see is i specified universalAPK to be true (which splits but also adds a universal apk) do u mean that has to be off or im missing something else?

On Fri, Jun 28, 2024, 8:14 AM linsui @.***> wrote:

and added the version code u mentioned

Thanks!

i believe its already split

Yep, but F-Droid needs to build the apks one by one so we need to set the abi for every build. I can patch the file but it would be better if I can set the abi easily. :)

— Reply to this email directly, view it on GitHub https://github.com/lovegaoshi/azusa-player-mobile/issues/502#issuecomment-2197154925, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZMOVVRDN3FVIJVBVOBDWXDZJV4UHAVCNFSM6AAAAABJ6ED7O2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJXGE2TIOJSGU . You are receiving this because you commented.Message ID: @.***>

[linsui]

Currently it builds 5 apks at the same time. But F-Droid needs to build them one by one. This is my current metadata. https://gitlab.com/linsui/fdroiddata/-/commit/ed3cdcc574de3c70dc825667e616b0a615c6e1a1 I patched the include line to build only the armv7 abi.

[lovegaoshi]

ah ok! updated now. https://github.com/lovegaoshi/azusa-player-mobile/commit/1659341e7234c9edef4100e82d13caf2b5062ba5

[linsui]

Thanks! It builds and works for me.