lovelace-dev-org / lovelace

Interactive Learning Environment
University of Illinois/NCSA Open Source License
4 stars 4 forks source link

evaluation group revisions are not considered when rendering #76

Open enkwolf opened 3 years ago

enkwolf commented 3 years ago

Evaluation group when rendering a task is always based on latest version. Doesn't have lasting effects, but the javascript side can mark an archived task that didn't belong to an evaluation group, but was added to one later, as credited. This bug is only cosmetic - if the page is reloaded the state of the mislabeled task is corrected.

Fixing this would involve using archived version when rendering embed frames. However, whether this causes problems elsewhere needs to be investigated first. It would also slow down rendering. An alternative solution would be to change what is sent in the json so that to-be-credited tasks would be decided on the server side, instead of just sending the evaluation group identifier.