lovele0107 / signatures-conformance-checker

7 stars 0 forks source link

Elliptic Curve certificates not supported + CommitmentTypeIndication issue #12

Open gbdslmad opened 3 years ago

gbdslmad commented 3 years ago

21-04-02.zip

Hello. I have identified two problems with the conformance checker. 1) X.509 certificates containing Elliptic Curve keys don't appear to be supported 2) It does not like it when I assign a commitment type to a specific object reference.

I have attached a ZIP containing an AdES, a copy of it pretty printed, the EU DSS tool output plus the ETSI errors.

Regards, Michael Adams

realmoieen commented 2 years ago

@gbdslmad I'm facing the same issue regarding EC key my XAdES Baseline Signatures are not validated by XAdESCC and giving me following errors image

and regarding your 2nd question of CommitmentType There is an issue with your signature as per ETSI pre EN 319 132-1 v1.0.0 Building Blocks and Baseline profile there must a single CommitmentTypeIndication/CommitmentTypeQualifiers/CommitmentTypeQualifier present. the correct way of adding CommitmentTypeIndication as per schema is

<xades:CommitmentTypeIndication>
    <xades:CommitmentTypeId>
        <xades:Identifier>http://uri.etsi.org/01903/v1.2.2#ProofOfSender</xades:Identifier>
    </xades:CommitmentTypeId>
    <xades:ObjectReference>#SignedDataObject_23038806361096</xades:ObjectReference>
    <xades:CommitmentTypeQualifiers>
        <xades:CommitmentTypeQualifier>sample commitment type qualifier value</xades:CommitmentTypeQualifier>
    </xades:CommitmentTypeQualifiers>
</xades:CommitmentTypeIndication>

if you add CommitmentTypeQualifiers in your signature then XAdESCC does not complain.