search

lovell / hepburn

Node.js module for converting Japanese Hiragana and Katakana script to, and from, Romaji using Hepburn romanisation
Apache License 2.0
130 stars 23 forks source link

Why no toKatakana? #3

Closed ronkorving closed 10 years ago

ronkorving commented 10 years ago

Is there a logic issue that makes that non-trivial?

lovell commented 10 years ago

Hi Ron, this should be entirely possible.

Any lack of implementation of Romaji to Katakana conversion is based purely, so far, on a lack of need. I believe co-conspirator @jeresig is converting to Romaji only.

A corpus of suitable unit tests, especially with some long vowel and N/M edge cases, would be an excellent place to start and I'd be more than happy to merge in a pull request providing this feature.

Cheers, Lovell

ronkorving commented 10 years ago

Excellent! And thanks for your quick reply. Please expect a PR (probably somewhere next week).

jeresig commented 10 years ago

@ronkorving Thanks for adding this, Ron!

ronkorving commented 10 years ago

You're very welcome, John! :)