search

lovell / hepburn

Node.js module for converting Japanese Hiragana and Katakana script to, and from, Romaji using Hepburn romanisation
Apache License 2.0
127 stars 23 forks source link

added contains kana utility method #9

Closed awsmsrc closed 10 years ago

awsmsrc commented 10 years ago

i don't know if i'm testing it the way you would like?? happy to take notes and guidance on this one! seems ok to me though, useful little utility functions for the lib IMHO as mentioned in issue #6

lovell commented 10 years ago

Thanks Luke, this is great. I'll add some documentation about these new methods and, more importantly, add you to the contributors list before publishing a new version to npm.

lovell commented 10 years ago

As we only need a boolean response, I took the liberty of modifying your contains methods to use the more efficient RegExp.test() instead of String.match(). Thanks for the unit tests that made it easy to make this change!

These methods are included in v0.6.0, now published to npm - enjoy!

awsmsrc commented 10 years ago

ahhh good stuff, I’m a rubyist most of the time so don’t know the standard object apis that well. that change sounds good!

Im looking to work on as much oss as possible so if you have an issue you don’t have time to fix feel free to pop me an email

On 15 Jun 2014, at 16:57, Lovell Fuller notifications@github.com wrote:

As we only need a boolean response, I took the liberty of modifying your contains methods to use the more efficient RegExp.test() instead of String.match(). Thanks for the unit tests that made it easy to make this change!

These methods are included in v0.6.0, now published to npm - enjoy!

— Reply to this email directly or view it on GitHub.